linux-kernel - Re: [PATCH 1/1] hidraw: Use Interrupt Endpoint for OUT Transfers if Available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1005181043390.28092@pobox.suse.cz>
Date:	Tue, 18 May 2010 10:44:10 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Alan Ott <alan@...nal11.us>
Cc:	Marcel Holtmann <marcel@...tmann.org>,
	Alan Stern <stern@...land.harvard.edu>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	David Fries <david@...es.net>, linux-usb@...r.kernel.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] hidraw: Use Interrupt Endpoint for OUT Transfers if
 Available

On Sun, 16 May 2010, Alan Ott wrote:

> From: Alan Ott <alan@...nal11.us>
> 
> This patch makes the hidraw driver use the first Interrupt OUT endpoint for
> HID transfers to the device if such an endpoint exists. This is consistent
> with the behavior of the hiddev driver, and the logic is similar.
> 
> Signed-off-by: Alan Ott <alan@...nal11.us>
> ---
> I believe this to be consistent with the section 4.4 of the HID 1.11
> specification located at:
>     http://www.usb.org/developers/devclass_docs/HID1_11.pdf
> 
> >From the specification (page numbered 10, the 20th page of the document
> (xpdf page 20)):
> 
>    The Interrupt Out pipe is optional. If a device declares an Interrupt Out
>    endpoint then Output reports are transmitted by the host to the device
>    through the Interrupt Out endpoint. If no Interrupt Out endpoint is
>    declared then Output reports are transmitted to a device through the
>    Control endpoint, using Set_Report(Output) requests.
> 
> This is also consistent with the way the Windows HID library (hid.dll)
> works.

Yes, this definitely is a proper improvement. Thanks Alan, I have queued 
the patch.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/