linux-kernel - Re: [PATCH 1/2] v4 x86/mrst: add cpu type detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 19 May 2010 12:19:04 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	jacob pan <jacob.jun.pan@...ux.intel.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>,
	Alek Du <alek.du@...el.com>, Alan Cox <alan@...ux.intel.com>,
	Feng Tang <feng.tang@...el.com>
Subject: Re: [PATCH 1/2] v4 x86/mrst: add cpu type detection

On Wed, 19 May 2010, jacob pan wrote:
> 
> >  Aside of that wouldn't it make more sense to do the chip
> >  identification only once from mrst_init() and cache the result and
> >  change mrst_identify_cpu()
> >
> the problem is again the ordering of cpuid, boot_cpu_data is not available
> by the time we call  x86_mrst_early_setup(). I can move it to mrst_time_init()

Hmm, right.

> but not very ideal. Unless we go back to do cpuid directly in the v1 patch :).

x86_init.oem.arch_setup() is the point where you can do that, that's
called after early_cpu_init() which fills boot_cpu_data. It's way
before the first user of mrst_chip.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/