linux-kernel - Re: [patch] pipe: add support for shrinking and growing pipes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikkRywJSJ8HFsVhVU9dHz8cFGqlK9ZHXZuGQbb2@mail.gmail.com>
Date:	Sun, 23 May 2010 07:30:01 +0200
From:	Michael Kerrisk <mtk.manpages@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Miklos Szeredi <miklos@...redi.hu>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, jens.axboe@...cle.com,
	akpm@...ux-foundation.org, Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [patch] pipe: add support for shrinking and growing pipes

Hi all,

I see that this patch has hit Linus's git, so some questions

On Wed, May 19, 2010 at 6:49 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
>
> On Wed, 19 May 2010, Miklos Szeredi wrote:
>>
>> One issue I see is that it's possible to grow pipes indefinitely.
>> Should this be restricted to privileged users?
>
> Yes. But perhaps only if it grows past the default (or perhaps "default*2"
> or similar). That way a normal user could shrink the pipe buffers, and
> then grow them again if he wants to.
>
> Oh, and I think you need to also require that there be at least two
> buffers. Otherwise we can't guarantee POSIX behavior, I think.

Is there any documentation (e.g., a man-pages patch) for these changes?

The argument of the fcntl() operations is expressed in pages. I take
it that this means that the semantics of the argument will very
depending on the system page size? So for example, 2 on x86 will mean
8192 bytes, but will mean 32768 of ia64? That seems very weird. (And
what about architectures where the page size is switchable?) Such
changes in semantics should not be silent for the use, IMO.

I'm not so sure about Linus's assertion above about needing at least
two buffers (pages?) to guarantee POSIX behavior. Back in 2.16.10 and
earlier, the buffer size was a page (4096 bytes) on x86-32, and we had
POSIX-compliant behavior.

Cheers,

Michael

-- 
Michael Kerrisk Linux man-pages maintainer;
http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface", http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/