linux-kernel - Re: [PATCH 01/10] perf, trace: Remove IRQ-disable from perf/tracepoint interaction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 May 2010 22:11:59 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] perf, trace: Remove IRQ-disable from
 perf/tracepoint interaction

On Fri, May 21, 2010 at 11:02:02AM +0200, Peter Zijlstra wrote:

>  	entry = (struct trace_entry *)raw_data;
> -	tracing_generic_entry_update(entry, *irq_flags, pc);
> +	tracing_generic_entry_update(entry, regs->flags, pc);
>  	entry->type = type;

This is breaking on powerpc -- we don't have a "flags" element in
struct pt_regs.  What is it trying to do?  Get the interrupt enable
state, as local_irq_save(flags) would provide?

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/