linux-kernel - Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100523123801.GC950@n2100.arm.linux.org.uk>
Date:	Sun, 23 May 2010 13:38:01 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	tom.leiming@...il.com
Cc:	linux-arm-kernel@...ts.infradead.org,
	linux-embedded@...r.kernel.org, a.p.zijlstra@...llo.nl,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

On Sun, May 23, 2010 at 07:48:48PM +0800, tom.leiming@...il.com wrote:
> diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S
> index 2c1db77..ed471a7 100644
> --- a/arch/arm/kernel/entry-common.S
> +++ b/arch/arm/kernel/entry-common.S
> @@ -58,7 +58,7 @@ work_resched:
>   */
>  ENTRY(ret_to_user)
>  ret_slow_syscall:
> -	disable_irq				@ disable interrupts
> +	disable_irq_notrace				@ disable interrupts

I think this one does need to be traced - the pending work functions are
all C code which could call back into lockdep.

Also, I'm nervious about applying this patch without seeing more people
test it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/