linux-kernel - Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikRp0EHxshKYq39p18ymoRNAtyHrNm3yq6A49-r@mail.gmail.com>
Date:	Sun, 23 May 2010 21:44:20 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	linux-arm-kernel@...ts.infradead.org,
	linux-embedded@...r.kernel.org, a.p.zijlstra@...llo.nl,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] ARM: fix 'unannotated irqs-on' lockdep warning

2010/5/23 Russell King - ARM Linux <linux@....linux.org.uk>:
>>  ENTRY(ret_to_user)
>>  ret_slow_syscall:
>> -     disable_irq                             @ disable interrupts
>> +     disable_irq_notrace                             @ disable interrupts
>
> I think this one does need to be traced - the pending work functions are
> all C code which could call back into lockdep.

If there are pending works, schedule will be called to give cpu to it, I wonder
why the work function to be scheduled will be run with irq disabled.
Seems we should enable irq again before calling schedule, not sure.

> Also, I'm nervious about applying this patch without seeing more people
> test it.

I test the patch on my beagle board and is OK, and if you don't apply one
patch into your tree, there are few people who may test it since they have to
parse the raw email patch(which is more inconvenient than 'git pull') for test
if they want to do.

Thanks,
-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/