linux-kernel - Re: BUG: using smp_processor_id() in preemptible [00000000] code: icedove-bin/5449

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1274781655.5882.765.camel@twins>
Date:	Tue, 25 May 2010 12:00:55 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	piotr@...owicz.com
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Jens Axboe <jens.axboe@...cle.com>,
	Divyesh Shah <dpshah@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: BUG: using smp_processor_id() in preemptible [00000000] code:
 icedove-bin/5449

On Tue, 2010-05-25 at 11:57 +0200, Piotr Hosowicz wrote:
> On 25.05.2010 11:43, Ingo Molnar wrote:
> 
> > This doesnt fix the whole issue. cpu_clock() is local, while the measurements
> > done in the blk code are global ...
> >
> > While the warning is fixed this way, the far more serious issue is still
> > there: time can go backwards if two points of time measurement are on
> > different CPUs and can mess up the statistics with negative values, etc...
> 
> How serious is this? Can it damage my data? I ask because the machine is 
> my private computer, not any test machine.

I'm not sure, since I didn't really look what they use the timestamps
for, but a guess would say your data is safe, it might schedule the io
funny, but it should not compromise integrity. At best its used purely
for statistics and not even behaviour is affected.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/