linux-kernel - Re: [PATCH] Staging: vme: vme.c: fixed an EXPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 May 2010 15:19:32 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	Greg KH <gregkh@...e.de>
CC:	nanakos@...ed-net.gr, wfp5p@...ginia.edu,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: vme: vme.c: fixed an EXPORT_SYMBOL warning

Greg KH wrote:
> On Tue, May 25, 2010 at 01:09:17PM +0000, nanakos@...ed-net.gr wrote:
>   
>> From: Nanakos Chrysostomos <nanakos@...ed-net.gr>
>>
>> Fixed an EXPORT_SYMBOL warning.
>>     
>
> What type of warning?  a checkpatch.pl one?  a gcc one?  a sparse one?
>
> Please be more verbose.
>
>   
>> Signed-off-by: Nanakos Chrysostomos <nanakos@...ed-net.gr>
>> ---
>>  drivers/staging/vme/vme.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c
>> index 093fbff..a0b63d5 100644
>> --- a/drivers/staging/vme/vme.c
>> +++ b/drivers/staging/vme/vme.c
>> @@ -1519,7 +1519,6 @@ struct bus_type vme_bus_type = {
>>  	.probe = vme_bus_probe,
>>  	.remove = vme_bus_remove,
>>  };
>> -EXPORT_SYMBOL(vme_bus_type);
>>  
>>  static int __init vme_init(void)
>>  {
>> @@ -1530,6 +1529,7 @@ static void __exit vme_exit(void)
>>  {
>>  	bus_unregister(&vme_bus_type);
>>  }
>> +EXPORT_SYMBOL(vme_bus_type);
>>     
>
> This does not look correct, why move this away from where the structure
> is defined?
>
>   

It's a checkpatch error:

$ scripts/checkpatch.pl -f drivers/staging/vme/vme.c
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#1522: FILE: staging/vme/vme.c:1522:
+EXPORT_SYMBOL(vme_bus_type);

total: 0 errors, 1 warnings, 1539 lines checked


> confused,
>   

Yup, confused me as well. :-)

Martyn

> greg k-h
>   


-- 
Martyn Welch (Principal Software Engineer)   |   Registered in England and
GE Intelligent Platforms                     |   Wales (3828642) at 100
T +44(0)127322748                            |   Barbirolli Square, Manchester,
E martyn.welch@...com                        |   M2 3AB  VAT:GB 927559189

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/