linux-kernel - Re: [PATCH] asm-generic: Use raw_local_irq_save/restore instead local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1274893911.22648.246.camel@gandalf.stny.rr.com>
Date:	Wed, 26 May 2010 13:11:51 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	monstr@...str.eu, linux-kernel@...r.kernel.org,
	michal.simek@...alogix.com, arnd@...db.de,
	john.williams@...alogix.com, tglx@...utronix.de,
	peter.fritzsche@....de, anton@...ba.org, mingo@...e.hu
Subject: Re: [PATCH] asm-generic: Use raw_local_irq_save/restore instead
 local_irq_save/restore

On Wed, 2010-05-26 at 10:08 -0700, Andrew Morton wrote:

> 
> If a developer looks at atomic_add_return() and asks himself "why did
> this use raw_local_irq_save()", the only way of answering that question
> is to go groveling through the git logs, which is a right PITA if
> you're trying to get some coding work done.
> 
> Guys, any time you add code which is non-obvious at the raw C level, it
> *needs* a comment!

Totally agree!  I've gotten pretty good at adding comments to changes
like this that I do. I need to get better at telling others to comment
their work ;-)

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/