linux-kernel - Re: [PATCH] Staging: rtl8192su: ieee80211: fix brace coding style issue and other issues in ieee80211_softmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100526202842.GO22515@bicker>
Date:	Wed, 26 May 2010 22:28:43 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Denis Kirjanov <kirjanov@...il.com>
Cc:	Bashlykov Arthur <madness@...ep.ru>, gregkh@...e.de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192su: ieee80211: fix brace coding style
	issue and other issues in ieee80211_softmac_wx.c

On Wed, May 26, 2010 at 10:48:08PM +0400, Denis Kirjanov wrote:
> On Wed, May 26, 2010 at 20:28 +0400, Bashlykov Arthur wrote:

> > -	if (!ieee->proto_started){
> > +	if (!ieee->proto_started) {
> >  		ieee->iw_mode = wrqu->mode;
> 
> I guess we can drop braces with single else statement

How Bashlykov has this is proper kernel style because the else statement
has more than one line.

> > -	}else{
> > +	} else {
> >  		ieee80211_stop_protocol(ieee);
> >  		ieee->iw_mode = wrqu->mode;
> >  		ieee80211_start_protocol(ieee);

The rest of your comments were correct of course.  Thanks for reviewing
this patch.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/