linux-kernel - Re: [PATCH] Staging: rtl8192su: ieee80211: fix brace coding style issue and other issues in ieee80211_softmac_wx.c Signed-off-by: Bashlykov Arthur <madness@...ep.ru>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201005270140.16354.sftp.mtuci@gmail.com>
Date:	Thu, 27 May 2010 01:40:15 +0400
From:	"Sergey V." <sftp.mtuci@...il.com>
To:	Bashlykov Arthur <madness@...ep.ru>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192su: ieee80211: fix brace coding style issue and other issues in ieee80211_softmac_wx.c Signed-off-by: Bashlykov Arthur <madness@...ep.ru>

On Wednesday 26 May 2010 20:28:57  Bashlykov Arthur wrote:

Hi Arthur

> @@ -87,15 +87,15 @@ int ieee80211_wx_get_freq(struct ieee80211_device *ieee,
>                            struct iw_request_info *a,
>                            union iwreq_data *wrqu, char *b)
>  {
> -     struct iw_freq *fwrq = & wrqu->freq;
> +     struct iw_freq *fwrq = &wrqu->freq;
>  
>       if (ieee->current_network.channel == 0)
>               return -1;
> -     //NM 0.7.0 will not accept channel any more.
> +     /* NM 0.7.0 will not accept channel any more. */
>       fwrq->m = ieee80211_wlan_frequencies[ieee->current_network.channel-1] * 100000;
>       fwrq->e = 1;
> -//   fwrq->m = ieee->current_network.channel;
> -//   fwrq->e = 0;
> +     /* fwrq->m = ieee->current_network.channel; */
> +     /* fwrq->e = 0; */
May be just remove dead code?

  
> @@ -230,13 +230,12 @@ int ieee80211_wx_get_rate(struct ieee80211_device *ieee,
>                            union iwreq_data *wrqu, char *extra)
>  {
>       u32 tmp_rate = 0;
> -     //printk("===>mode:%d, halfNmode:%d\n", ieee->mode, ieee->bHalfWirelessN24GMode);
> +     /* printk("===>mode:%d, halfNmode:%d\n", ieee->mode, ieee->bHalfWirelessN24GMode); */
Same


> @@ -529,33 +520,33 @@ int ieee80211_wx_set_power(struct ieee80211_device *ieee,
>  {
>       int ret = 0;
>  #if 1
> -     if(
> +     if {
>               (!ieee->sta_wake_up) ||
> -     //      (!ieee->ps_request_tx_ack) ||
> +     /*      (!ieee->ps_request_tx_ack) || */
Same
>               (!ieee->enter_sleep_state) ||
> -             (!ieee->ps_is_queue_empty)){
> +             (!ieee->ps_is_queue_empty)) {
>  
> -     //      printk("ERROR. PS mode is tryied to be use but driver missed a callback\n\n");
> +     /* printk("ERROR. PS mode is tryied to be use but driver missed a callback\n\n"); */
Same
>  
>               return -1;
>       }
>  #endif
>       down(&ieee->wx_sem);
>  
> -     if (wrqu->power.disabled){
> +     if (wrqu->power.disabled) {
>               ieee->ps = IEEE80211_PS_DISABLED;
>               goto exit;
>       }
>       if (wrqu->power.flags & IW_POWER_TIMEOUT) {
> -             //ieee->ps_period = wrqu->power.value / 1000;
> +             /*ieee->ps_period = wrqu->power.value / 1000; */
Same
>               ieee->ps_timeout = wrqu->power.value / 1000;
>       }
>  
>       if (wrqu->power.flags & IW_POWER_PERIOD) {
>  
> -             //ieee->ps_timeout = wrqu->power.value / 1000;
> +             /* ieee->ps_timeout = wrqu->power.value / 1000; */
Same
>               ieee->ps_period = wrqu->power.value / 1000;
> -             //wrq->value / 1024;
> +             /* wrq->value / 1024; */
Same
>  
>       }
>       switch (wrqu->power.flags & IW_POWER_MODE) {
> @@ -570,7 +561,7 @@ int ieee80211_wx_set_power(struct ieee80211_device *ieee,
>               break;
>  
>       case IW_POWER_ON:
> -     //      ieee->ps = IEEE80211_PS_DISABLED;
> +      /* ieee->ps = IEEE80211_PS_DISABLED; */
Same


> @@ -604,15 +595,15 @@ int ieee80211_wx_get_power(struct ieee80211_device *ieee,
>               wrqu->power.flags = IW_POWER_TIMEOUT;
>               wrqu->power.value = ieee->ps_timeout * 1000;
>       } else {
> -//           ret = -EOPNOTSUPP;
> -//           goto exit;
> +             /* ret = -EOPNOTSUPP; */
> +             /* goto exit; */
Same
>               wrqu->power.flags = IW_POWER_PERIOD;
>               wrqu->power.value = ieee->ps_period * 1000;
> -//ieee->current_network.dtim_period * ieee->current_network.beacon_interval * 1024;
> +/*ieee->current_network.dtim_period * ieee->current_network.beacon_interval * 1024; */
Same
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/