linux-kernel - Re: [PATCH] perf: fix use_browser infinite loop bug in annotate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinrLDskqxBbrCa6XJ45yp-pdhwWkrj65a47Tb52@mail.gmail.com>
Date:	Thu, 27 May 2010 17:52:42 +0200
From:	Stephane Eranian <eranian@...gle.com>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	paulus@...ba.org, davem@...emloft.net, fweisbec@...il.com,
	perfmon2-devel@...ts.sf.net, eranian@...il.com
Subject: Re: [PATCH] perf: fix use_browser infinite loop bug in annotate

On Thu, May 27, 2010 at 5:45 PM, Arnaldo Carvalho de Melo
<acme@...radead.org> wrote:
> Em Thu, May 27, 2010 at 11:51:42AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Thu, May 27, 2010 at 02:50:01PM +0200, Stephane Eranian escreveu:
>> > This patch fixes an infinite loop problem with perf annotate when
>> > the TUI is not used. When the perfconfig file is not found use_browser
>> > remains at -1, when found and tui is disabled use_browser = 0. Thus the
>> > correct test for TUI is use_browser > 0.
>> >
>> > Signed-off-by: Stephane Eranian <eranian@...gle.com>
>>
>> Thanks, I'm applying this one and doing an audit of other uses, I know
>> of one more case reported by Frédéric that was fixed in a similar way.
>
>        Oops, I already have this fixed on changeset
>
> 62e3436b5f3461662929eae102beefbd12127cb1
>
>        That is at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf
>
> http://git.kernel.org/?p=linux/kernel/git/acme/linux-2.6.git;a=commit;h=62e3436b5f3461662929eae102beefbd12127cb1
>
>        I pushed this to Ingo yesterday, should be in tip/perf/core soon,
> thanks anyway!
>
Ok, if it's fixed then this is fine. The other problem I reported is
more important.
Thanks for checking.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/