linux-kernel - Re: [PATCHv4 14/17] UDF: do not manipulate s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100525140646.GC3783@quack.suse.cz>
Date:	Tue, 25 May 2010 16:06:46 +0200
From:	Jan Kara <jack@...e.cz>
To:	Artem Bityutskiy <dedekind1@...il.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-fsdevel@...r.kernel.org, Jan Kara <jack@...e.cz>
Subject: Re: [PATCHv4 14/17] UDF: do not manipulate s_dirt directly

On Tue 25-05-10 16:49:09, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> 
> ... use new VFS helpers instead.
  Looks. OK. You can add
Acked-by: Jan Kara <jack@...e.cz>

							Honza

> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> Cc: Jan Kara <jack@...e.cz>
> ---
>  fs/udf/super.c   |    6 +++---
>  fs/udf/udfdecl.h |    2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/udf/super.c b/fs/udf/super.c
> index 1e4543c..998c911 100644
> --- a/fs/udf/super.c
> +++ b/fs/udf/super.c
> @@ -1940,7 +1940,7 @@ static int udf_fill_super(struct super_block *sb, void *options, int silent)
>  	sb->s_op = &udf_sb_ops;
>  	sb->s_export_op = &udf_export_ops;
>  	sb->dq_op = NULL;
> -	sb->s_dirt = 0;
> +	mark_sb_clean(sb);
>  	sb->s_magic = UDF_SUPER_MAGIC;
>  	sb->s_time_gran = 1000;
>  
> @@ -2067,7 +2067,7 @@ static void udf_error(struct super_block *sb, const char *function,
>  
>  	if (!(sb->s_flags & MS_RDONLY)) {
>  		/* mark sb error */
> -		sb->s_dirt = 1;
> +		mark_sb_dirty(sb);
>  	}
>  	va_start(args, fmt);
>  	vsnprintf(error_buf, sizeof(error_buf), fmt, args);
> @@ -2127,7 +2127,7 @@ static int udf_sync_fs(struct super_block *sb, int wait)
>  		 * the buffer for IO
>  		 */
>  		mark_buffer_dirty(sbi->s_lvid_bh);
> -		sb->s_dirt = 0;
> +		mark_sb_clean(sb);
>  		sbi->s_lvid_dirty = 0;
>  	}
>  	mutex_unlock(&sbi->s_alloc_mutex);
> diff --git a/fs/udf/udfdecl.h b/fs/udf/udfdecl.h
> index 9079ff7..9337e3f 100644
> --- a/fs/udf/udfdecl.h
> +++ b/fs/udf/udfdecl.h
> @@ -120,7 +120,7 @@ static inline void udf_updated_lvid(struct super_block *sb)
>  	WARN_ON_ONCE(((struct logicalVolIntegrityDesc *)
>  		     bh->b_data)->integrityType !=
>  		     cpu_to_le32(LVID_INTEGRITY_TYPE_OPEN));
> -	sb->s_dirt = 1;
> +	mark_sb_dirty(sb);
>  	UDF_SB(sb)->s_lvid_dirty = 1;
>  }
>  
> -- 
> 1.6.6.1
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/