linux-kernel - Re: [PATCH v2 3/4]: sendfile: remove flags paramter of do_splice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimzsHAxha3vQxeFn5pF5BmYZ8nLawSG2YU3eujZ@mail.gmail.com>
Date:	Fri, 28 May 2010 18:06:18 +0800
From:	Changli Gao <xiaosuo@...il.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	axboe@...nel.dk, viro@...iv.linux.org.uk, matthew@....cx,
	mszeredi@...e.cz, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4]: sendfile: remove flags paramter of 
	do_splice_direct()

On Fri, May 28, 2010 at 5:40 PM, Miklos Szeredi <miklos@...redi.hu> wrote:
> On Wed, 26 May 2010, Changli Gao wrote:
>> remove flags paramter of do_splice_direct().
>>
>> the flags parameter of do_splice_direct() doesn't mean non-block read of
>> in file,
>
> Actually, it does.  Look at the SPLICE_F_NONBLOCK usage in
> __generic_splice_file_read().
>

Oh, I checked the code again. You're right. However, why don't we
check the flags of in file instead in __generic_file_splice_read()?

-- 
Regards，
Changli Gao(xiaosuo@...il.com)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/