linux-kernel - Re: [PATCH 11/17] fs/xfs/quota: Add missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 May 2010 12:57:32 -0500
From:	Alex Elder <aelder@....com>
To:	Julia Lawall <julia@...u.dk>
Cc:	xfs-masters@....sgi.com, xfs@....sgi.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 11/17] fs/xfs/quota: Add missing mutex_unlock

On Wed, 2010-05-26 at 17:57 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> Add a mutex_unlock missing on the error path.  The use of this lock is
> balanced elsewhere in the file.

Looks good.  I'll pull this one into the XFS tree.

Reviewed-by: Alex Elder <aelder@....com>

> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression E1;
> @@
> 
> * mutex_lock(E1,...);
>   <+... when != E1
>   if (...) {
>     ... when != E1
> *   return ...;
>   }
>   ...+>
> * mutex_unlock(E1,...);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> ---
> The use of ENOMEM rather than -ENOMEM is also a bit odd.
> 
>  fs/xfs/quota/xfs_qm.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c
> index 38e7641..2d8b7bc 100644
> --- a/fs/xfs/quota/xfs_qm.c
> +++ b/fs/xfs/quota/xfs_qm.c
> @@ -249,8 +249,10 @@ xfs_qm_hold_quotafs_ref(
>  
>  	if (!xfs_Gqm) {
>  		xfs_Gqm = xfs_Gqm_init();
> -		if (!xfs_Gqm)
> +		if (!xfs_Gqm) {
> +			mutex_unlock(&xfs_Gqm_lock);
>  			return ENOMEM;
> +		}
>  	}
>  
>  	/*



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/