linux-kernel - Re: [PATCH 2/2] fs: optimize mpage_bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100529124735.GB25092@liondog.tnic>
Date:	Sat, 29 May 2010 14:47:35 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Changli Gao <xiaosuo@...il.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] fs: optimize mpage_bio_submit()

From: Changli Gao <xiaosuo@...il.com>
Date: Sat, May 29, 2010 at 09:19:26AM +0800

> optimize mpage_bio_submit()
> 
> check rw, then initialize bio->bi_end_io.
> 
> Signed-off-by: Changli Gao <xiaosuo@...il.com>
> ----
>  fs/mpage.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> diff --git a/fs/mpage.c b/fs/mpage.c
> index 94ff0d1..632681c 100644
> --- a/fs/mpage.c
> +++ b/fs/mpage.c
> @@ -85,9 +85,7 @@ static void mpage_end_io_write(struct bio *bio, int err)
>  
>  static struct bio *mpage_bio_submit(int rw, struct bio *bio)
>  {
> -	bio->bi_end_io = mpage_end_io_read;
> -	if (rw == WRITE)
> -		bio->bi_end_io = mpage_end_io_write;
> +	bio->bi_end_io = rw != WRITE ? mpage_end_io_read : mpage_end_io_write;
>  	submit_bio(rw, bio);
>  	return NULL;

ok, can you sincerely tell me that your change makes the code more
readable? And have you checked to see what the compiler actually
"optimizes"?

original code:

	movq	$mpage_end_io_read, %rdx	#, tmp65
	movq	$mpage_end_io_write, %rax	#, tmp64
	cmpl	$1, %edi	#, rw
	cmovne	%rdx, %rax	# tmp65,, tmp64
	movq	%rax, 80(%rsi)	# tmp64, <variable>.bi_end_io
	.loc 1 91 0
	call	submit_bio	#

your change:

	movq	$mpage_end_io_read, %rdx	#, tmp63
	movq	$mpage_end_io_write, %rax	#, iftmp.561
	cmpl	$1, %edi	#, rw
	cmovne	%rdx, %rax	# tmp63,, iftmp.561
	movq	%rax, 80(%rsi)	# iftmp.561, <variable>.bi_end_io
	.loc 1 90 0
	call	submit_bio	#

so that change does nothing except obfuscating the source a bit more so
that you get more headaches whenever you look at it.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/