linux-kernel - Re: [PATCH] tracing: Add task activate/deactivate tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1275330522.1645.523.camel@laptop>
Date:	Mon, 31 May 2010 20:28:42 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	rostedt@...dmis.org
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: Add task activate/deactivate tracepoints

On Mon, 2010-05-31 at 12:37 -0400, Steven Rostedt wrote:
> >  
> > +#ifdef CREATE_TRACE_POINTS
> 
> I guess this could work. I can't think of anything that would cause this
> to fail. But this is not exactly what the CREATE_TRACE_POINTS macro was
> for.
> 
> Maybe we could make a CREATE_UTIL_FUNCTIONS macro that the
> define_trace.h can unset like it does with CREATE_TRACE_POINTS before
> recursively including the trace headers.
> 
> Maybe I'm a bit paranoid, but I'm a little nervous to extend the
> CREATE_TRACE_POINTS macro to be used within the header to create utility
> functions, although, currently I don't think there's anything
> technically wrong in doing so. 

Right, I can attest to the compile mess that results in not having
it :-) Given that, I think we're fairly safe with stretching it like
this, the compiler will yell real loud if you mess this up. So I'm not
sure you need to be very paranoid about this.

Duplicating the whole CREATE_TRACE_POINT logic just for a different name
doesn't seem worth the effort at this time, esp. given the compiler
results if you get it wrong.

So do you object if I merge this for now, or would you really rather see
something else?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/