linux-kernel - Re: [PATCH] usb-serial/ftdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Jun 2010 07:27:31 -0700
From:	Greg KH <gregkh@...e.de>
To:	Daniel Mack <daniel@...aq.de>
Cc:	linux-kernel@...r.kernel.org, Johan Hovold <jhovold@...il.com>,
	Alan Cox <alan@...ux.intel.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb-serial/ftdi_sio: fix DTR/RTS line modes

On Thu, Jun 03, 2010 at 01:57:27PM +0200, Daniel Mack wrote:
> On Thu, Jun 03, 2010 at 01:55:02PM +0200, Daniel Mack wrote:
> > Call set_mctrl() and clear_mctrl() according to the flow control mode
> > selected. This makes serial communication for FT232 connected devices
> > work when CRTSCTS is not set.
> > 
> > This fixes a regression introduced by 4175f3e31 ("tty_port: If we are
> > opened non blocking we still need to raise the carrier"). This patch
> > calls the low-level driver's dtr_rts() function which consequently sets
> > TIOCM_DTR | TIOCM_RTS. A later call to set_termios() without CRTSCTS in
> > cflags, however, does not reset these bits, and so data is not actually
> > sent out on the serial wire.
> > 
> > Signed-off-by: Daniel Mack <daniel@...aq.de>
> > Cc: Greg Kroah-Hartman <gregkh@...e.de>
> > Cc: Johan Hovold <jhovold@...il.com>
> > Cc: Alan Cox <alan@...ux.intel.com>
> > Cc: linux-usb@...r.kernel.org
> 
> Oops. I forgot to Cc: stable@...nel.org.
> This is in fact broken since 2.6.31-something.

Thanks for letting me know, I'll add that marking to the patch when I
queue it up.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/