linux-kernel - Re: floppy driver assumes INITIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100603144913.24828629@nehalam>
Date:	Thu, 3 Jun 2010 14:49:13 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: floppy driver assumes INITIAL_JIFFIES == 0

It seems it isn't related to initial jiffies. 
Initializing the values (though a good idea), doesn't solve the
problem. Still failed.  So dazed and confused, went back and reran
kernel with jiffies=0 showed same problem, just took multiple boots
to reproduce.

>  	for (dr = 0; dr < N_DRIVE; dr++) {
> @@ -4267,6 +4269,9 @@ static int __init floppy_init(void)
>  		set_bit(FD_DISK_CHANGED_BIT, &UDRS->flags);
>  		set_bit(FD_VERIFY_BIT, &UDRS->flags);
>  		UDRS->fd_device = -1;
> +		UDRS->last_checked = jiffies;
> +		UDRS->select_date = jiffies;
> +		UDRS->spinup_date = jiffies;
>  		floppy_track_buffer = NULL;
>  		max_buffer_sectors = 0;
>  	}

So still a race that shows up with KVM (fast floppy?) and manifests
as floppy_ready or reset_interrupt OOPS.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/