linux-kernel - Re: BUG: sched:sched_migrate_task event tracing returns incorrect events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1276182701.2077.462.camel@twins>
Date:	Thu, 10 Jun 2010 17:11:41 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ronny Tschüter <Ronny.Tschueter@...dresden.de>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: BUG: sched:sched_migrate_task event tracing returns incorrect
 events

On Thu, 2010-06-10 at 16:56 +0200, Ronny Tschüter wrote:
> Hi,
> 
> I want to know a little bit more about the execution of my program. 
> Especially I'm interested in cpu migrations of my process. Therefore I 
> use the Linux performance counter infrastructure, set appropriate 
> perf_event attributes and setup the sched:sched_migrate_task event with 
> a system call:
> ...
> attr.type = PERF_TYPE_TRACEPOINT;
> attr.size = sizeof( struct perf_event_attr );
> attr.config = event_id; // id of sched:sched_migrate_task event
> attr.sample_type = PERF_SAMPLE_TIME|PERF_SAMPLE_CPU|PERF_SAMPLE_RAW;
> attr.freq = 0;
> attr.sample_freq = 1;
> fd = syscall( __NR_perf_counter_open, &attr, getpid(), -1, -1, 0 );
> ...
> Finally to read the events I map the kernel event buffer via mmap and 
> process every event in this buffer. However I run into two problems:
> 
> (1) I need root privileges to open the counter successfully. Without 
> root privileges syscall returns -1. I think that is not OK because users 
> should be allowed to create per task counters.

It is, because you specify PERF_SAMPLE_RAW, which is considered a data
leak for unpriv users.

> (2) The buffer contains events that aren't caused by my process (i.e. 
> the COMM field does not contain the name of my process and the PID field 
> is not equal to the pid of my process).

I think that could happen if the migration happens from interrupt
context while your task is running. Also wakeups your process does can
result in migrations of the woken task from the context of your task.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/