| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100611045007.GC16436@laptop> Date: Fri, 11 Jun 2010 14:50:07 +1000 From: Nick Piggin <npiggin@...e.de> To: Tao Ma <tao.ma@...cle.com> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, Joel Becker <joel.becker@...cle.com>, Christoph Hellwig <hch@....de> Subject: Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence. On Fri, Jun 11, 2010 at 11:27:49AM +0800, Tao Ma wrote: > Let ocfs2 use the new truncate sequence. The changes include: > 1. Move inode_change_ok into cluster lock and remove inode_newsize_ok. > 2. Use truncate_setsize directly since we don't implement our > own ->truncate and what we need is "update i_size and > truncate_pagecache" which truncate_setsize now does. > 3. Change some i_size_read to inode->i_size in ocfs2_setattr > since we have i_muext held. > 4. For direct write, ocfs2 actually don't allow write to pass > i_size(see ocfs2_prepare_inode_for_write), so we don't have > a chance to increase i_size. So remove the bogus check. > > Cc: Joel Becker <joel.becker@...cle.com> > Cc: Christoph Hellwig <hch@....de> > Cc: Nick Piggin <npiggin@...e.de> The patch looks fine to me. I really appreciate you working on truncate, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists