linux-kernel - Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C11E2BD.2020207@oracle.com>
Date:	Fri, 11 Jun 2010 15:16:13 +0800
From:	Tao Ma <tao.ma@...cle.com>
To:	Christoph Hellwig <hch@....de>
CC:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joel Becker <joel.becker@...cle.com>,
	Nick Piggin <npiggin@...e.de>, "tao.ma" <tao.ma@...cle.com>
Subject: Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence.

Hi Christoph,

On 06/11/2010 02:56 PM, Christoph Hellwig wrote:
> This looks correct, but still has the second if ATTR_SIZE block that
> I commented on last time.  I'd really prefer if the filesystems could
> move the truncate handling into a single conditional to simplify
> auditing for it and possibly splitting it out into a separate method
> later.
oh, that would be much work for ocfs2 to do from my perspective. So I 
would really want to leave it as-is and I have add it to my to-do list.
>
> And btw, the S_ISREG check which you only have on the first ATTR_SIZE
> check is superflous, the VFS only does ATTR_SIZE calls on regular files.
yeah, I can remove it.

Regards,
Tao
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/