linux-kernel - Re: Noticeable slow-down in 2.6.35-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201006131813.04096.gene.heskett@gmail.com>
Date:	Sun, 13 Jun 2010 18:13:04 -0400
From:	Gene Heskett <gene.heskett@...il.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Noticeable slow-down in 2.6.35-rc3

On Sunday 13 June 2010, Chris Clayton wrote:
>On Sunday 13 June 2010 21:58:09 Chris Clayton wrote:
>> On Sunday 13 June 2010 21:35:25 François Valenduc wrote:
>> > Le 13/06/10 22:15, Chris Clayton a écrit :
>>
>> <snip>
>>
>> > > I've bisected it and arrived at:
>> > >
>> > > 597a264b1a9c7e36d1728f677c66c5c1f7e3b837 is the first bad commit
>> > > commit 597a264b1a9c7e36d1728f677c66c5c1f7e3b837
>> > > Author: John Fastabend <john.r.fastabend@...el.com>
>> > > Date:   Thu Jun 3 09:30:11 2010 +0000
>>
>> <snip>
>>
>> > This commit also makes nfsd hangs at startup on my computer (see
>> > https://bugzilla.kernel.org/show_bug.cgi?id=16195). This problem
>> > doesn't occur if it's reverted.
>>
>> I've just found John Fastabend's easy and fast fix
>> (http://marc.info/?l=linux-kernel&m=127646140827821) and am about to
>> apply it and test the new kernel. back soon!
>
>Yes, that's fixed the problem I reported.
>
Unfortunately, this patch will not apply to my src tree for 2.6.35-rc3, 
even after I fixed the unwanted line wrap in the first active line.

I get:

[root@...ote linux-2.6.35-rc3]# patch -p1 <../2.6.35-rc3-test.patch
patching file net/core/skbuff.c
Hunk #1 FAILED at 532.
1 out of 1 hunk FAILED -- saving rejects to file net/core/skbuff.c.rej

Did my grabbing it with swiftfox damage it even further?
------------------------------------------------------------------
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 9f07e74..bcf2fa3 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -532,6 +532,7 @@ static void __copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
  	new-&gt;ip_summed		= old-&gt;ip_summed;
  	skb_copy_queue_mapping(new, old);
  	new-&gt;priority		= old-&gt;priority;
+	new-&gt;deliver_no_wcard	= old-&gt;deliver_no_wcard;
  #if defined(CONFIG_IP_VS) || defined(CONFIG_IP_VS_MODULE)
  	new-&gt;ipvs_property	= old-&gt;ipvs_property;
  #endif
---------------------------------------------------------------

That line 532 is not at line 532 in my src tree, its at line 516 here.

I have seen this sort of thing before when using bz2 src files, but this is
all from gzipped stuffs.  ???

Thanks for any hints.

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
Depends on how you define "always".  :-)
             -- Larry Wall in <199710211647.JAA17957@...l.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/