linux-kernel - Re: [PATCH V2 0/4] Add MMC erase and secure erase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100614112150.GA5364@lst.de>
Date:	Mon, 14 Jun 2010 13:21:50 +0200
From:	Christoph Hellwig <hch@....de>
To:	Adrian Hunter <adrian.hunter@...ia.com>
Cc:	Christoph Hellwig <hch@....de>,
	"jens.axboe@...cle.com" <jens.axboe@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Kyungmin Park <kmpark@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	Madhusudhan Chikkature <madhu.cr@...com>
Subject: Re: [PATCH V2 0/4] Add MMC erase and secure erase

On Mon, Jun 14, 2010 at 02:10:06PM +0300, Adrian Hunter wrote:
> Needs a bio flag, a request flag, setup the request flag based on the
> bio flag, prevent merging secure and non-secure discards, prevent drivers
> doing non-secure discards for secure discards.
> 
> Seems like a lot of little changes for something that no one wants.
> Shouldn't it wait for someone to need it first?

I know that some people have asked for this.  But if you want to keep
it in the driver for now that's fine to me.  But in that case please:

 (a) make it entirely driver private and leave no traces of it in the
     block layer
 (b) split it into a separate patch from the discard support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/