linux-kernel - Re: BUG: using smp_processor_id() in preemptible code: s2disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100614145439.GA3448@swordfish.minsk.epam.com>
Date:	Mon, 14 Jun 2010 17:54:40 +0300
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
	Jiri Slaby <jslaby@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: BUG: using smp_processor_id() in preemptible code: s2disk

On (06/14/10 07:38), Arjan van de Ven wrote:
> > Hello,
> > Not sure if this simple solution is the correct one.
> 
> it's not; the caller needs to pass in the cpu number I suspect for this
> to be really correct....
> 
> I just returned from family emergency travel and will take a look today
> 

I thought about patching

./drivers/cpuidle/governors/menu.c:	if (nr_iowait_cpu())
./drivers/cpuidle/governors/menu.c:	mult += 10 * nr_iowait_cpu();
./kernel/time/tick-sched.c:		if (nr_iowait_cpu() > 0)


decided to patch nr_iowait_cpu instead.


	Sergey

Content of type "application/pgp-signature" skipped