linux-kernel - Re: [PATCH v2] drivers: regulator: add Maxim 8998 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100615131452.GF14510@rakim.wolfsonmicro.main>
Date:	Tue, 15 Jun 2010 14:14:52 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	'Liam Girdwood' <lrg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com,
	sameo@...ux.intel.com
Subject: Re: [PATCH v2] drivers: regulator: add Maxim 8998 driver

On Tue, Jun 15, 2010 at 02:38:26PM +0200, Marek Szyprowski wrote:

> Are global exports preferred over the callbacks? I saw both in different
> MFD drivers and was not sure which one to use.

> I've selected callbacks, because they are a bit nicer and don't pollute
> the name space for each single driver. In my opinion the cost of these
> 3 max8998_reg_{read,write,update} inline functions in regulator/max8998.c
> is not so significant.

The dereferences looked fairly painful reading the code.  You can always
do the global stuff as static inlines in the header file which avoids
namespace pollution while keeping the code looking like a function call.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/