linux-kernel - RE: [PATCH v2] drivers: regulator: add Maxim 8998 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <010f01cb0d12$a18484a0$e48d8de0$%szyprowski@samsung.com>
Date:	Wed, 16 Jun 2010 07:13:13 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	'Mark Brown' <broonie@...nsource.wolfsonmicro.com>
Cc:	'Liam Girdwood' <lrg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org, kyungmin.park@...sung.com,
	sameo@...ux.intel.com,
	'Marek Szyprowski' <m.szyprowski@...sung.com>
Subject: RE: [PATCH v2] drivers: regulator: add Maxim 8998 driver

Hello,

On Tuesday, June 15, 2010 3:15 PM Mark Brown wrote:

> On Tue, Jun 15, 2010 at 02:38:26PM +0200, Marek Szyprowski wrote:
> 
> > Are global exports preferred over the callbacks? I saw both in different
> > MFD drivers and was not sure which one to use.
> 
> > I've selected callbacks, because they are a bit nicer and don't pollute
> > the name space for each single driver. In my opinion the cost of these
> > 3 max8998_reg_{read,write,update} inline functions in regulator/max8998.c
> > is not so significant.
> 
> The dereferences looked fairly painful reading the code.  You can always
> do the global stuff as static inlines in the header file which avoids
> namespace pollution while keeping the code looking like a function call.

Ok, I will provide a patch that moves {read,write,update}_reg functions to
linux/mfs/max8998-private.h soon.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/