linux-kernel - Re: [PATCH] alsa: riptide: don't use own hex_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h1vc6m7ed.wl%tiwai@suse.de>
Date:	Thu, 17 Jun 2010 09:43:06 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andy Shevchenko <ext-andriy.shevchenko@...ia.com>,
	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org
Subject: Re: [PATCH] alsa: riptide: don't use own hex_to_bin() method

At Tue, 15 Jun 2010 17:26:28 +0300,
Andy Shevchenko wrote:
> 
> From: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
> 
> Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@...ia.com>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: alsa-devel@...a-project.org

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/riptide/riptide.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index ad44626..59d7996 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -97,6 +97,7 @@
>  #include <linux/gameport.h>
>  #include <linux/device.h>
>  #include <linux/firmware.h>
> +#include <linux/kernel.h>
>  #include <asm/io.h>
>  #include <sound/core.h>
>  #include <sound/info.h>
> @@ -667,13 +668,12 @@ static u32 atoh(const unsigned char *in, unsigned int len)
>  	unsigned char c;
>  
>  	while (len) {
> +		int value;
> +
>  		c = in[len - 1];
> -		if ((c >= '0') && (c <= '9'))
> -			sum += mult * (c - '0');
> -		else if ((c >= 'A') && (c <= 'F'))
> -			sum += mult * (c - ('A' - 10));
> -		else if ((c >= 'a') && (c <= 'f'))
> -			sum += mult * (c - ('a' - 10));
> +		value = hex_to_bin(c);
> +		if (value >= 0)
> +			sum += mult * value;
>  		mult *= 16;
>  		--len;
>  	}
> -- 
> 1.6.6.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/