linux-kernel - Re: [PATCH 00/14] tracing: add compat syscall support v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jun 2010 09:46:15 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Ian Munsie <imunsie@....ibm.com>
Cc:	Jason Baron <jbaron@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/14] tracing: add compat syscall support v3

On Thu, Jun 17, 2010 at 05:39:07PM +1000, Ian Munsie wrote:
> Excerpts from Jason Baron's message of Fri May 21 23:24:07 +1000 2010:
> > On Fri, May 21, 2010 at 07:40:21PM +1000, Ian Munsie wrote:
> > > Hi Jason,
> > > 
> > > I'm currently in the process of implementing syscall tracepoints for
> > > PowerPC, and a considerable amount of my work is going to end up
> > > requiring these patches of yours. I've reviewed and tested your patches
> > > (and spent a good chunk of time rebasing them on top of
> > > tip/tracing/core) and they all seem pretty good.
> > > 
> > > I *particularly* like the way in which they prevent ftrace syscalls from
> > > reporting that sys_swapoff was constantly firing on x86_64 kernels with
> > > a 32bit userspace ;)
> > > 
> > > Anyway, I'm just wondering if you have an ETA for the v4 patchset to
> > > address the remaining issues that Frederic raised so that they can be
> > > merged.
> > > 
> > > Cheers,
> > > -Ian
> > > 
> > 
> > hi Ian,
> > 
> > I think the main issue left was that I am using the same meta data for
> > both the 32-bit and 64-bit table entries, when they reference the same
> > syscall. for example, for x86 both the compat and underlying 64-bit
> > kernel reference 'sys_rename'. Thus, i am pointing both perf events at
> > the same meta data. Frederic was saying they need to be separate. I'm
> > not sure i completely understand why, since the 32-bit are just sign
> > extended to 64-bit in this case. Frederic, perhaps, you can explain this
> > a bit more for me?
> > 
> > thanks,
> > 
> > -Jason
> 
> Hi Jason,
> 
> I'm currently cleaning up my patch series for ftrace syscalls on PowerPC
> and want to release it soon.
> 
> It's probably easiest for me if I release your compat syscall support v3
> patches as part of the series. You'd still be marked as the author of
> those commits - the only changes I have made to them was rebasing them
> against the current tip tree and resolving the conflicts that I came
> across.



Perfect! I was about to ask Jason to rebase his patchset against latest -tip.

If you send this set, please also add your own Signed-off-by.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/