[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.00.1006171557470.3401@kaball-desktop>
Date: Thu, 17 Jun 2010 16:42:02 +0100
From: Stefano Stabellini <stefano.stabellini@...citrix.com>
To: Jeremy Fitzhardinge <jeremy@...p.org>
CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
"ddutile@...hat.com" <ddutile@...hat.com>,
"sheng@...ux.intel.com" <sheng@...ux.intel.com>
Subject: Re: [Xen-devel] [PATCH 06/12] Allow xen platform pci device to be
compiled as a module
On Tue, 15 Jun 2010, Jeremy Fitzhardinge wrote:
> On 06/14/2010 10:20 PM, Konrad Rzeszutek Wilk wrote:
> >> -static inline unsigned int max_nr_grant_frames(void)
> >> +unsigned int gnttab_max_nr_grant_frames(void)
> >> {
> >> unsigned int xen_max = __max_nr_grant_frames();
> >>
> >> @@ -444,6 +445,7 @@ static inline unsigned int max_nr_grant_frames(void)
> >> return boot_max_nr_grant_frames;
> >> return xen_max;
> >> }
> >> +EXPORT_SYMBOL_GPL(gnttab_max_nr_grant_frames);
> >>
> > Prefix the name with 'xen_' ? That is a mouthfull thought:
> >
> > Xen Grant Table Max Nr Grant Frames. How about 'xen_gnttab_max_frames' ?
> >
>
> Unfortunately the gnttab API is generally lacking xen_ prefixes. It's
> better to keep this consistent, and then maybe sort them all out together.
>
I renamed it to gnttab_max_grant_frames for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists