linux-kernel - Re: [Xen-devel] [PATCH 05/12] Add suspend\resume support for PV on HVM guests.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1006171635150.3401@kaball-desktop>
Date:	Thu, 17 Jun 2010 16:42:08 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jeremy@...p.org" <jeremy@...p.org>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"ddutile@...hat.com" <ddutile@...hat.com>,
	"sheng@...ux.intel.com" <sheng@...ux.intel.com>
Subject: Re: [Xen-devel] [PATCH 05/12] Add suspend\resume support for PV on
 HVM guests.

On Mon, 14 Jun 2010, Konrad Rzeszutek Wilk wrote:
> > +static int platform_pci_resume(struct pci_dev *pdev)
> > +{
> > +	int err;
> > +	if (xen_have_vector_callback)
> > +		return 0;
> > +	err = xen_set_callback_via(callback_via);
> > +	if (err) {
> > +		printk("platform_pci_resume failure!\n");
> 
> How did you scripts/checkpatch.pl --strict let you do that?
> You might want to use dev_err instead.
> 

I'll do that and re-run checkpatch.pl on the whole series

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/