linux-kernel - RE: [PATCH 5/12] scsi: megaraid_sas - Online Controller Reset (OCR): Add and initialize the OCR relaed variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jun 2010 11:00:48 -0600
From:	"Yang, Bo" <Bo.Yang@....com>
To:	James Bottomley <James.Bottomley@...e.de>
CC:	"'linux-scsi@...r.kernel.org'" <linux-scsi@...r.kernel.org>,
	"'akpm@...l.org'" <akpm@...l.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 5/12] scsi: megaraid_sas - Online Controller Reset
 (OCR): Add and initialize the OCR relaed variable

James,

Thanks, I will re-submit the patches 5-12.

Regards,

Bo Yang

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@...e.de] 
Sent: Thursday, June 17, 2010 12:20 PM
To: Yang, Bo
Cc: 'linux-scsi@...r.kernel.org'; 'akpm@...l.org'; 'linux-kernel@...r.kernel.org'
Subject: Re: [PATCH 5/12] scsi: megaraid_sas - Online Controller Reset (OCR): Add and initialize the OCR relaed variable

On Wed, 2010-06-09 at 21:54 -0600, Yang, Bo wrote:
> To support online controller reset, driver need to define some
> instance based variable and initialize them.

This doesn't compile:

  CC [M]  drivers/scsi/megaraid/megaraid_sas.o
drivers/scsi/megaraid/megaraid_sas.c: In function
‘megasas_deplete_reply_queue’:
drivers/scsi/megaraid/megaraid_sas.c:2090: warning: unused variable
‘fw_state’
drivers/scsi/megaraid/megaraid_sas.c: In function ‘megasas_init_mfi’:
drivers/scsi/megaraid/megaraid_sas.c:3023: error: ‘struct
megasas_ctrl_prop’ has no member named ‘OnOffProperties’
drivers/scsi/megaraid/megaraid_sas.c: In function ‘megasas_probe_one’:
drivers/scsi/megaraid/megaraid_sas.c:3486: error:
‘process_fw_state_change_wq’ undeclared (first use in this function)
drivers/scsi/megaraid/megaraid_sas.c:3486: error: (Each undeclared
identifier is reported only once
drivers/scsi/megaraid/megaraid_sas.c:3486: error: for each function it
appears in.)

Because OnOffProperties structure is defined in patch 6/12 as is the
process_fw_state_change_wq function.

I've got 1-4 ... please resubmit 5-12 so they actually build in the
order submitted.

Thanks,

James