linux-kernel - Re: [PATCH 1/2] Staging: comedi: fix code style errors in s626.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100617203424.GA32523@kroah.com>
Date:	Thu, 17 Jun 2010 13:34:24 -0700
From:	Greg KH <greg@...ah.com>
To:	John Sheehan <john.d.sheehan@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, roel.kluin@...il.com,
	jkosina@...e.cz, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: comedi: fix code style errors in s626.c

On Fri, May 28, 2010 at 04:31:28PM +0100, John Sheehan wrote:
> From: John Sheehan <john.d.sheehan@...il.com>
> 
> A patch for s626.c to fix errors reported by
> checkpatch.pl tool, namely,
> code indent should use tabs where possible
> "foo * bar" should be "foo *bar"
> trailing statements should be on next line
> 
> Signed-off-by: John Sheehan <john.d.sheehan@...il.com>
> ---
>  drivers/staging/comedi/drivers/s626.c |   67 +++++++++++++++++++--------------
>  1 files changed, 39 insertions(+), 28 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
> index a3cc933..83e1bb1 100644
> --- a/drivers/staging/comedi/drivers/s626.c
> +++ b/drivers/staging/comedi/drivers/s626.c
> @@ -60,10 +60,10 @@ INSN_CONFIG instructions:
>     insn.insn=INSN_CONFIG;   //configuration instruction
>     insn.n=1;                //number of operation (must be 1)
>     insn.data=&initialvalue; //initial value loaded into encoder
> -                            //during configuration
> +							//during configuration

Why change this?

>     insn.subdev=5;           //encoder subdevice
>     insn.chanspec=CR_PACK(encoder_channel,0,AREF_OTHER); //encoder_channel
> -                                                        //to configure
> +														//to configure

Why is this line indented so much now?

Care to resend this without these changes?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/