linux-kernel - Re: [PATCH 1/3] mfd: add STMPExxxx I/O Expander support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100619135016.GA6825@pengutronix.de>
Date:	Sat, 19 Jun 2010 15:50:16 +0200
From:	Luotao Fu <l.fu@...gutronix.de>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Rabin Vincent <rabin.vincent@...ricsson.com>,
	linux-kernel@...r.kernel.org, STEricsson_nomadik_linux@...t.st.com,
	Linus Walleij <linus.walleij@...ricsson.com>,
	l.fu@...gutronix.de
Subject: Re: [PATCH 1/3] mfd: add STMPExxxx I/O Expander support

Hi,

On Sat, Jun 19, 2010 at 01:42:24AM +0200, Samuel Ortiz wrote:
> Hi Rabin,
> 
> On Mon, May 31, 2010 at 05:47:14PM +0530, Rabin Vincent wrote:
> > Add support for the STMPExxxx family of I/O Expanders from
> > STMicroelectronics.  These devices include upto 24 gpios, a PWM
> > controller, and a keypad controller.  This patch adds the MFD core.
> The patchset looks fairly good, but before merging it I'd like to know of we
> could merge it with this one:
> https://patchwork.kernel.org/patch/106173/
> 
> I don't know enough about the hardware, and although the register layouts don't
> look like they have much in common, I'd like to know from the actual HW
> manufacturer (i.e. you :)) if there's something we can do here.
> I'm cc'ing Luotao here so that we get his input as well.
> 

hmm, I took a quick look into the core driver. The register layout
seems, as Samuel mentioned, quite different. However, the r/w
functionalities and irq handling are quite the same. For now I'd say
that should be possible to merge the stuff.

cheers
Luotao Fu

-- 
Pengutronix e.K.                           | Dipl.-Ing. Luotao Fu        |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)