linux-kernel - Re: [PATCH] SOUND: usb/endpoint, fix dangling pointer use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100621150515.GB17833@buzzloop.caiaq.de>
Date:	Mon, 21 Jun 2010 17:05:16 +0200
From:	Daniel Mack <daniel@...aq.de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	tiwai@...e.de, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Clemens Ladisch <clemens@...isch.de>
Subject: Re: [PATCH] SOUND: usb/endpoint, fix dangling pointer use

On Mon, Jun 21, 2010 at 05:03:21PM +0200, Jiri Slaby wrote:
> Stanse found that in snd_usb_parse_audio_endpoints, there is a
> dangling pointer dereference. When snd_usb_parse_audio_format fails,
> fp is freed, and continue invoked. On the next loop, there is
> "fp && fp->altsetting == 1 && fp->channels == 1" test, but fp is set
> from the last iteration (but is bogus) and thus ilegally dereferenced.
> 
> Set fp to NULL before "continue".

Oh, absolutely. Thanks.

> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Acked-by: Daniel Mack <daniel@...aq.de>

I think this should go thru the ALSA tree.


Daniel


> Cc: Clemens Ladisch <clemens@...isch.de>
> Cc: Takashi Iwai <tiwai@...e.de>
> ---
>  sound/usb/endpoint.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
> index 9593b91..6f6596c 100644
> --- a/sound/usb/endpoint.c
> +++ b/sound/usb/endpoint.c
> @@ -427,6 +427,7 @@ int snd_usb_parse_audio_endpoints(struct snd_usb_audio *chip, int iface_no)
>  		if (snd_usb_parse_audio_format(chip, fp, format, fmt, stream, alts) < 0) {
>  			kfree(fp->rate_table);
>  			kfree(fp);
> +			fp = NULL;
>  			continue;
>  		}
>  
> -- 
> 1.7.1
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/