linux-kernel - Re: [PATCH] SOUND: usb/endpoint, fix dangling pointer use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hwrts2zjk.wl%tiwai@suse.de>
Date:	Mon, 21 Jun 2010 17:09:03 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Daniel Mack <daniel@...aq.de>
Cc:	Jiri Slaby <jslaby@...e.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Clemens Ladisch <clemens@...isch.de>
Subject: Re: [PATCH] SOUND: usb/endpoint, fix dangling pointer use

At Mon, 21 Jun 2010 17:05:16 +0200,
Daniel Mack wrote:
> 
> On Mon, Jun 21, 2010 at 05:03:21PM +0200, Jiri Slaby wrote:
> > Stanse found that in snd_usb_parse_audio_endpoints, there is a
> > dangling pointer dereference. When snd_usb_parse_audio_format fails,
> > fp is freed, and continue invoked. On the next loop, there is
> > "fp && fp->altsetting == 1 && fp->channels == 1" test, but fp is set
> > from the last iteration (but is bogus) and thus ilegally dereferenced.
> > 
> > Set fp to NULL before "continue".
> 
> Oh, absolutely. Thanks.
> 
> > Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> 
> Acked-by: Daniel Mack <daniel@...aq.de>
> 
> I think this should go thru the ALSA tree.

Yep, I applied it now.  Thanks!


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/