linux-kernel - Re: linux-next: Tree for June 21 (staging/easycap)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100621090049.c7f11c2d.randy.dunlap@oracle.com>
Date:	Mon, 21 Jun 2010 09:00:49 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>, gregkh@...e.de,
	devel@...verdev.osuosl.org
Cc:	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for June 21 (staging/easycap)

On Mon, 21 Jun 2010 17:00:56 +1000 Stephen Rothwell wrote:

> Hi all,
> 
> Changes since 20100618:

When CONFIG_USB is not enabled:

ERROR: "usb_kill_urb" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_deregister_dev" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "video_register_device" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_deregister" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "video_unregister_device" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_set_interface" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_register_dev" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_control_msg" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_submit_urb" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_get_dev" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_find_interface" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_register_driver" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_free_urb" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "usb_alloc_urb" [drivers/staging/easycap/easycap.ko] undefined!

Adding "depends on USB" to EASYCAP is a good start.
After that and enabling CONFIG_USB, build of easycap gets:

ERROR: "video_register_device" [drivers/staging/easycap/easycap.ko] undefined!
ERROR: "video_unregister_device" [drivers/staging/easycap/easycap.ko] undefined!

because there is no media/video support enabled.  Also no SOUND enabled,
so I expect there to be build errors associated with sound also, meaning that
the Kconfig file should probably modified with something like

config EASYCAP
+	depends on USB && VIDEO_DEV && SND

This is something that the driver author should know the answer to and submit a
patch for.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/