linux-kernel - Re: [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C1F8FD2.6090809@gmail.com>
Date:	Mon, 21 Jun 2010 09:14:10 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
CC:	reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun'
 set but not used

On 06/21/2010 05:34 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 14 Jun 2010 22:48:34 -0700
> "Justin P. Mattock"<justinmattock@...il.com>  escreveu:
>
>> Resend due to a whitespace issue I created by mistake.
>> The below patch fixes a warning message create by gcc 4.6.0
>
> It seems OK for me, but you shouldn't be sending it to be applied at reiserfs-devel ML.
> Instead, it should be sent to linux-media ML, and applied via my tree.
>

I should of used get_maintainer.pl to find the correct list to send this 
too(instead I just looked into the MAINTAINERS file).
I'll resend.

>>
>>   CC [M]  drivers/media/common/tuners/tuner-simple.o
>> drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq':
>> drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used
>>
>>   Signed-off-by: Justin P. Mattock<justinmattock@...il.com>
>>   Reviewed-By: Mauro Carvalho Chehab<mchehab@...hat.com>
>>
>> ---
>>   drivers/media/common/tuners/tuner-simple.c |    3 ---
>>   1 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c
>> index 8abbcc5..84900fa 100644
>> --- a/drivers/media/common/tuners/tuner-simple.c
>> +++ b/drivers/media/common/tuners/tuner-simple.c
>> @@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe,
>>   	struct tuner_simple_priv *priv = fe->tuner_priv;
>>   	u8 config, cb;
>>   	u16 div;
>> -	struct tunertype *tun;
>>   	u8 buffer[4];
>>   	int rc, IFPCoff, i;
>>   	enum param_type desired_type;
>>   	struct tuner_params *t_params;
>>
>> -	tun = priv->tun;
>> -
>>   	/* IFPCoff = Video Intermediate Frequency - Vif:
>>   		940  =16*58.75  NTSC/J (Japan)
>>   		732  =16*45.75  M/N STD
>
>

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/