linux-kernel - Re: [PATCH] tracing: Fix undelared ENOSYS in include/linux/tracepoint.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1277137261.9181.21.camel@gandalf.stny.rr.com>
Date:	Mon, 21 Jun 2010 12:21:01 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	Wu Zhangjin <wuzhangjin@...il.com>, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Masami Hiramatsu <mhiramat@...hat.com>
Subject: Re: [PATCH] tracing: Fix undelared ENOSYS in
 include/linux/tracepoint.h

On Mon, 2010-06-21 at 11:47 -0400, Mathieu Desnoyers wrote:
> * Steven Rostedt (rostedt@...dmis.org) wrote:
> > On Mon, 2010-06-21 at 19:09 +0800, Wu Zhangjin wrote:
> > > From: Wu Zhangjin <wuzhangjin@...il.com>
> > > 
> > > The header file include/linux/tracepoint.h may be included without
> > > include/linux/errno.h and then the compiler will fail on building for
> > > undelcared ENOSYS. This patch fixes this problem via including <linux/errno.h>
> > > to include/linux/tracepoint.h.
> > > 
> > 
> > Hi Wu,
> > 
> > I have not hit this. Did you hit this with mips? Does it need to get
> > into 2.6.35 or can it wait till 2.6.36?
> 
> errno.h is included by sched.h, which is included almost everywhere. No
> wonder it took that much time for someone to hit the problem. But given
> it's a simple bug fix, it should fit into the "for-2.6.35" definition,
> although I am no expert in these definitions. ;-)

Usually I would agree. But lately Linus has been very strict in what
goes into 35.

Thus, I would say, it should go into 35 if it breaks a configuration
build of things already in 35. Otherwise, it can wait till 36.

Of course this is an extremely trivial fix, and maybe there's a
configuration already in 35 that we don't know about that this bug can
break. I guess I'll just pull it in for a 35 push.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/