[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100623165936.661744f8@lxorguk.ukuu.org.uk>
Date: Wed, 23 Jun 2010 16:59:36 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Andi Kleen <andi@...stfloor.org>
Cc: Kees Cook <kees.cook@...onical.com>,
linux-security-module@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] security: Yama LSM
> > I actually think this is a flaw in get_task_comm. (Though actually it's
> > the fault of terminals if they process dangerous escape sequences. Worst
> > case tends to just be confusing output, but that's not important --
> > nothing should spew non-printables regardless.) Would a patch to
> > get_task_comm be accepted to replace non-printables with "?" or something
> > when filling the buffer?
>
> Probably makes sense, although you might annoy someone who wants Kanji
> process names in UTF-8 or similar.
The task name is irrelevant, user controlled information. It's not
really ideal for use in security logging.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists