[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20100623191007.GD15787@basil.fritz.box>
Date: Wed, 23 Jun 2010 21:10:07 +0200
From: Andi Kleen <andi@...stfloor.org>
To: Alan Cox <alan@...rguk.ukuu.org.uk>
Cc: Andi Kleen <andi@...stfloor.org>,
Kees Cook <kees.cook@...onical.com>,
linux-security-module@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v2] security: Yama LSM
On Wed, Jun 23, 2010 at 04:59:36PM +0100, Alan Cox wrote:
> > > I actually think this is a flaw in get_task_comm. (Though actually it's
> > > the fault of terminals if they process dangerous escape sequences. Worst
> > > case tends to just be confusing output, but that's not important --
> > > nothing should spew non-printables regardless.) Would a patch to
> > > get_task_comm be accepted to replace non-printables with "?" or something
> > > when filling the buffer?
> >
> > Probably makes sense, although you might annoy someone who wants Kanji
> > process names in UTF-8 or similar.
>
> The task name is irrelevant, user controlled information. It's not
> really ideal for use in security logging.
Yes but the pid only is normally completely useless, because nobody
knows afterwards what some old pid was.
-Andi
--
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists