linux-kernel - Re: [regression, bisected] SysRq commands trigger without holding sysrq.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1006270710210.7802@i5.linux-foundation.org>
Date:	Sun, 27 Jun 2010 07:12:53 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [regression, bisected] SysRq commands trigger without holding
 sysrq.



On Mon, 14 Jun 2010, Nick Bowler wrote:
>
> It appears that the new SysRq handling stuff totally ignores key
> releases: I don't have to hold down any of the keys to trigger sysrq
> commands.  For example, if I press and release left-alt, then press and
> release print screen, then press b, the system reboots.  The order in
> which I press the keys matters, but I can press other keys between them
> and still trigger sysrq commands (e.g. I can press and release alt, type
> a bunch, press print screen, then start triggering commands by pressing
> letters).
> 
> The result is that it is very easy to accidentally trigger sysrq
> commands, to the detriment of a system's usefulness.  It also renders
> the printscreen key completely useless after either alt key has been
> pressed once since system bootup (printscreen works fine until alt is
> pressed).
> 
> Bisection reveals the following, and reverting the implicated commit
> (resolving a trivial conflict) solves the issue.
> 
> 97f5f0cd8cd0a05449cbb77d1e6f02e026875802 is the first bad commit

Dmitry? I didn't see any follow-ups on this issue, should I just do the 
revert, or is there some better fix?

There's another report about this from Éric Piel.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/