linux-kernel - Re: [PATCH 1/5] staging: slicoss: Change return codes to -EYYY.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100628111409.GA20103@shinshilla>
Date:	Mon, 28 Jun 2010 15:14:09 +0400
From:	Kulikov Vasiliy <segooon@...il.com>
To:	dkirjanov@...nel.org
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, Lior Dotan <liodot@...il.com>,
	charrer@...critech.com, "David S. Miller" <davem@...emloft.net>,
	Jiri Pirko <jpirko@...hat.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: slicoss: Change return codes to -EYYY.

> > @@ -1206,7 +1206,7 @@ static void slic_link_event_handler(struct adapter *adapter)
> >  #else
> >        Stop compilation;
> >  #endif
> > -       ASSERT((status == STATUS_SUCCESS) || (status == STATUS_PENDING));
> > +       ASSERT(status == 0);
> >  }
> >
> 
> Now that looks useless since slic_upr_request can return STATUS_PENDING
> or -ENOMEM. Same for slic_config_get
Yes, it seems that slic_link_event_handler & slic_config_get have to return error codes.

> > @@ -2267,7 +2267,7 @@ static u32 slic_card_locate(struct adapter *adapter)
> >
> >        ASSERT(card);
> >        if (!card)
> > -               return STATUS_FAILURE;
> > +               return -ENOMEM;
> 
> Is -ENOMEM correct for this case?
> 
Right, maybe ENXIO?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/