linux-kernel - Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22319.1277826461@redhat.com>
Date:	Tue, 29 Jun 2010 16:47:41 +0100
From:	David Howells <dhowells@...hat.com>
To:	"Justin P. Mattock" <justinmattock@...il.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, lenb@...nel.org
Subject: Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used

Justin P. Mattock <justinmattock@...il.com> wrote:

> +	if (fn) {
> + 			printk(KERN_WARNING "dev%d: Failed to create
> firmware_node: %d\n", status, fn);
> +	}else if (pn) {
> +			printk(KERN_WARNING "dev%d: Failed to create
> physical_node: %d\n", status, pn);
> + 			return 0;
> +		}

The if-statement should be correctly indented (it's inside another
if-body, so needs to be one more tab over) and there needs to be a space
before the else.

You should probably split your printks up so they don't exceed 80 chars too,
for example:

			printk(KERN_WARNING
			       "dev%d: Failed to create physical_node: %d\n",
			       status, pn);

Also 'status' is probably the wrong thing to print as the number in "dev%d".
If it worked, that should be unconditionally AE_OK, I think.  Can you not use
dev_warn() or similar instead or printk?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/