linux-kernel - Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," to terminate statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1277838161.15226.11.camel@Joe-Laptop.home>
Date:	Tue, 29 Jun 2010 12:02:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86 <x86@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," to
 terminate statements

On Tue, 2010-06-29 at 02:14 +0200, Ingo Molnar wrote:
> * Joe Perches <joe@...ches.com> wrote:
> 
> > Needed if pr_<level> becomes a bit more space efficient.
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > ---
> >  arch/x86/kernel/cpu/mtrr/cleanup.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/cpu/mtrr/cleanup.c b/arch/x86/kernel/cpu/mtrr/cleanup.c
> > index 06130b5..c5f59d0 100644
> > --- a/arch/x86/kernel/cpu/mtrr/cleanup.c
> > +++ b/arch/x86/kernel/cpu/mtrr/cleanup.c
> > @@ -632,9 +632,9 @@ static void __init mtrr_print_out_one_result(int i)
> >  	unsigned long gran_base, chunk_base, lose_base;
> >  	char gran_factor, chunk_factor, lose_factor;
> >  
> > -	gran_base = to_size_factor(result[i].gran_sizek, &gran_factor),
> > -	chunk_base = to_size_factor(result[i].chunk_sizek, &chunk_factor),
> > -	lose_base = to_size_factor(result[i].lose_cover_sizek, &lose_factor),
> > +	gran_base = to_size_factor(result[i].gran_sizek, &gran_factor);
> > +	chunk_base = to_size_factor(result[i].chunk_sizek, &chunk_factor);
> > +	lose_base = to_size_factor(result[i].lose_cover_sizek, &lose_factor);
> 
> That file and this subsystem needs a lot more cleanups than just this. Would 
> you be willing to do them all, so that we can get over with the churn in a 
> single well-defined patch (or patches)?
> 
> I dont see much point in piecemail single-comma patches - i'd rather wait for 
> someone else who'd fix this and other details in one go.

This is the only "," preceeding a pr_<level> printk
in the kernel tree.

The comma prevents the pr_<level> macro to take the
"do { foo } while (0)" form.

I don't see significant issues in the code style that
need cleanups in arch/x86/kernel/cpu/mtrr.

What do you think needs cleaning?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/