linux-kernel - Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," to terminate statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1277770962.29157.283.camel@Joe-Laptop.home>
Date:	Mon, 28 Jun 2010 17:22:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86 <x86@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch/x86/kernel/cpu/mtrr/cleanup.c: Use ";" not "," to
 terminate statements

On Tue, 2010-06-29 at 02:14 +0200, Ingo Molnar wrote:
> That file and this subsystem needs a lot more cleanups than just this. Would 
> you be willing to do them all, so that we can get over with the churn in a 
> single well-defined patch (or patches)?
> 
> I dont see much point in piecemail single-comma patches - i'd rather wait for 
> someone else who'd fix this and other details in one go.

I don't see significant style issues in mtrr

$ git ls-files arch/x86/kernel/cpu/mtrr/ | \
	xargs ./scripts/checkpatch.pl -f 

What do you think needs improving?git ls-files arch/x86/kernel/cpu/mtrr/
| \
	xargs ./scripts/checkpatch.pl -f 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/