linux-kernel - Re: BUG in drivers/dma/ioat/dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C2C3B07.7050200@intel.com>
Date:	Wed, 30 Jun 2010 23:51:51 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	"Woodhouse, David" <david.woodhouse@...el.com>
CC:	Chris Li <lkml@...isli.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: BUG in drivers/dma/ioat/dma_v2.c:314

On 6/30/2010 11:21 PM, Woodhouse, David wrote:
> On Wed, 2010-06-30 at 22:44 +0100, Williams, Dan J wrote:
>> I don't see a way around this beyond blacklisting this (platform, vt-d
>> setting, driver) combination.  Is there a quirk infrastructure for this
>> sort of problem?
>
> Yeah, kind of. If the IOAT PCI device _always_ has its own IOMMU, we
> could have a quirk for it which says it must _never_ be matched by a
> catch-all IOMMU. That would probably solve it?
>

This version of the device only exists on the 5400 chipset and always 
has its own iommu, but since other platforms get the DMAR entry right I 
think this hammer is too big?  Wouldn't this break VT-d operation on 
non-busted platforms?

Alternatively I can just catch this failure earlier in the init process 
and fail the driver load with a grumble printk about broken bios... 
instead of the current BUG_ON() that is meant to catch runtime catastrophes.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/