linux-kernel - Re: BUG in drivers/dma/ioat/dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1277968336.4945.3.camel@localhost>
Date:	Thu, 01 Jul 2010 08:12:16 +0100
From:	David Woodhouse <David.Woodhouse@...el.com>
To:	"Williams, Dan J" <dan.j.williams@...el.com>
Cc:	Chris Li <lkml@...isli.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: BUG in drivers/dma/ioat/dma_v2.c:314

On Thu, 2010-07-01 at 07:51 +0100, Williams, Dan J wrote:
> On 6/30/2010 11:21 PM, Woodhouse, David wrote:
> > On Wed, 2010-06-30 at 22:44 +0100, Williams, Dan J wrote:
> >> I don't see a way around this beyond blacklisting this (platform, vt-d
> >> setting, driver) combination.  Is there a quirk infrastructure for this
> >> sort of problem?
> >
> > Yeah, kind of. If the IOAT PCI device _always_ has its own IOMMU, we
> > could have a quirk for it which says it must _never_ be matched by a
> > catch-all IOMMU. That would probably solve it?
> >
> 
> This version of the device only exists on the 5400 chipset and always 
> has its own iommu, but since other platforms get the DMAR entry right I 
> think this hammer is too big?  Wouldn't this break VT-d operation on 
> non-busted platforms?

That just means we have to get the quirk right. Does 'this version' of
the device have its own PCI ID? We can always fall back to checking the
ID of the device at 0000:00:00.0 to check which chipset we're on.

> Alternatively I can just catch this failure earlier in the init process 
> and fail the driver load with a grumble printk about broken bios... 
> instead of the current BUG_ON() that is meant to catch runtime catastrophes.

Please use WARN_TAINT(TAINT_FIRMWARE_WORKAROUND). That way the
statistics end up in kerneloops.org and we have found that extremely
useful when LARTing the offending vendors.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/