linux-kernel - Re: [PATCH 1/7] Add a target to use the Coccinelle checker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C2E47E9.5090408@suse.cz>
Date:	Fri, 02 Jul 2010 22:11:21 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	Nicolas Palix <npalix@...u.dk>,
	Randy Dunlap <rdunlap@...otime.net>,
	Roland Dreier <rdreier@...co.com>,
	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Sam Ravnborg <sam@...nborg.org>, Julia Lawall <julia@...u.dk>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	cocci@...u.dk, Wolfram Sang <w.sang@...gutronix.de>,
	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	Américo Wang <xiyou.wangcong@...il.com>,
	Andy Isaacson <adi@...apodia.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	walter harms <wharms@....de>, Joerg Roedel <joro@...tes.org>,
	Jan Engelhardt <jengelh@...ozas.de>
Subject: Re: [PATCH 1/7] Add a target to use the Coccinelle checker

On 30.6.2010 20:58, Kulikov Vasiliy wrote:
>> +if [ "$COCCI" = "" ] ; then
>> +    for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
>> +	coccinelle $f $srctree;
>> +    done
>> +else
>> +    coccinelle $COCCI $srctree
>> +fi
> 
> I think it is more usefull to use $M instead of $srctree to run simple
> 'make coccicheck'.

Good idea, but
1) The right variable to look for is $KBUILD_EXTMOD
2) If this is not set, the script should check files in $srctree as before

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/