linux-kernel - Re: [PATCH 1/7] Add a target to use the Coccinelle checker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Jul 2010 16:30:34 +0200
From:	Nicolas Palix <npalix@...u.dk>
To:	Kulikov Vasiliy <segooon@...il.com>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Roland Dreier <rdreier@...co.com>,
	Joe Perches <joe@...ches.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Michal Marek <mmarek@...e.cz>, Sam Ravnborg <sam@...nborg.org>,
	Julia Lawall <julia@...u.dk>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	cocci@...u.dk, Wolfram Sang <w.sang@...gutronix.de>,
	Kernel Janitors <kernel-janitors@...r.kernel.org>,
	Américo Wang <xiyou.wangcong@...il.com>,
	Andy Isaacson <adi@...apodia.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	walter harms <wharms@....de>, Joerg Roedel <joro@...tes.org>,
	Jan Engelhardt <jengelh@...ozas.de>
Subject: Re: [PATCH 1/7] Add a target to use the Coccinelle checker

On Friday 02 July 2010 15:52:50 Kulikov Vasiliy wrote:
> On Wed, Jun 30, 2010 at 23:52 +0200, Nicolas Palix wrote:
> > On Wednesday 30 June 2010 20:58:54 Kulikov Vasiliy wrote:
> > > > +if [ "$COCCI" = "" ] ; then
> > > > +    for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> > > > +	coccinelle $f $srctree;
> > > > +    done
> > > > +else
> > > > +    coccinelle $COCCI $srctree
> > > > +fi
> > > 
> > > I think it is more usefull to use $M instead of $srctree to run simple
> > > 'make coccicheck'.
> > 
> > What is the purpose of $M ?
> > 
> > I submitted an incremental patch to add support for $C.
> 
> From root Makefile:
> # Use make M=dir to specify directory of external module to build
> # Old syntax make ... SUBDIRS=$PWD is still supported
> # Setting the environment variable KBUILD_EXTMOD take precedence
> 
> So, I compile all local modules as smth like
> make -C ../../.. M=$PWD CONFIG_SMTH=m modules
> 
> If coccinelle is started as 'coccinelle $COCCI $M' then it checks only in
> directory tree with $M root.

That would be great indeed. And we can still use $srctree as a default
value if $M is not set. Coccinelle already support this scheme with the
combination of -dir and -patch, so the paths in the generated patches/messages
can be fixed.

Kulikov, would you like to make the patch ?


> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
Nicolas Palix
Web: http://www.diku.dk/~npalix/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/